Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/uipath/src/uipath/_cli/_chat/_voice_bridge.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@
self._done = asyncio.Event()
self._in_flight: set[asyncio.Task[None]] = set()
self._end_reason: VoiceSessionEndReason | None = None
self._end_detail: dict[str, Any] = {}

@property
def end_detail(self) -> dict[str, Any]:
"""CAS payload from voice_session_ended, preserved for the job runtime."""
return self._end_detail

async def run(self) -> VoiceSessionEndReason:
"""Connect, dispatch tool calls until session ends, then disconnect.
Expand Down Expand Up @@ -214,8 +220,16 @@
tool_result.is_error,
)

async def _handle_session_ended(self, _data: Any, *_: Any) -> None:
logger.info("[Voice] voice_session_ended received")
async def _handle_session_ended(self, data: Any = None, *_: Any) -> None:

Check warning on line 223 in packages/uipath/src/uipath/_cli/_chat/_voice_bridge.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use asynchronous features in this function or remove the `async` keyword.

See more on https://sonarcloud.io/project/issues?id=UiPath_uipath-python&issues=AZ8ACHA29pL_5KuGapqk&open=AZ8ACHA29pL_5KuGapqk&pullRequest=1764
detail = data if isinstance(data, dict) else {}
self._end_detail = detail
logger.info(
"[Voice] voice_session_ended received "
"(endedBy=%s, callEnded=%s, reason=%s)",
detail.get("endedBy"),
detail.get("callEnded"),
detail.get("reason"),
)
self._end_session(VoiceSessionEndReason.COMPLETED)


Expand Down
26 changes: 26 additions & 0 deletions packages/uipath/tests/cli/chat/test_voice_bridge.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,32 @@ async def test_session_ended_sets_completed(self) -> None:
await session._handle_session_ended(None)
assert session._end_reason == VoiceSessionEndReason.COMPLETED

async def test_session_ended_preserves_payload_opaquely(self) -> None:
session = _make_session()
call_context = {"type": "phone", "id": "CA123", "conversationId": "conv-1"}
payload = {
"callContext": call_context,
"conversationId": "conv-1",
"endedBy": "agent",
"callEnded": False,
"reason": "agent_completed",
"someFutureKey": {"nested": True},
}

await session._handle_session_ended(payload)

assert session.end_detail == payload
assert session.end_detail["callContext"] == call_context
assert session.end_detail["endedBy"] == "agent"
assert session.end_detail["callEnded"] is False
assert session._end_reason == VoiceSessionEndReason.COMPLETED

async def test_session_ended_non_dict_payload_is_empty_detail(self) -> None:
session = _make_session()
await session._handle_session_ended("not-a-dict")
assert session.end_detail == {}
assert session._end_reason == VoiceSessionEndReason.COMPLETED

async def test_disconnect_sets_disconnected(self) -> None:
session = _make_session()
await session._handle_disconnect()
Expand Down
Loading