[test trigger 2]#1751
Closed
radu-mocanu wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the evaluation CLI/runtime tracing by (1) adding an optional local trace export target and (2) introducing higher-level OpenTelemetry spans around evaluation-set runs, individual evaluations, and evaluator executions.
Changes:
- Add
--trace-filetouipath evaland register aJsonLinesFileExporterwhen provided. - Wrap eval-set execution, per-eval execution, and evaluator execution in new OpenTelemetry spans with custom attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/uipath/_cli/cli_eval.py |
Adds a --trace-file CLI option and wires up JSONL trace exporting during eval. |
src/uipath/_cli/_evals/_runtime.py |
Adds new OpenTelemetry spans around eval set runs, evaluations, and evaluator execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+305
to
+308
| span_attributes = { | ||
| "execution.id": self.execution_id, | ||
| "span_type": "eval_set_run", | ||
| } |
Comment on lines
+398
to
+403
| attributes={ | ||
| "execution.id": execution_id, | ||
| "span_type": "evaluation", | ||
| "eval_item_id": eval_item.id, | ||
| "eval_item_name": eval_item.name, | ||
| } |
Comment on lines
+730
to
+735
| result = await evaluator.validate_and_evaluate_criteria( | ||
| agent_execution=agent_execution, | ||
| evaluation_criteria=evaluation_criteria, | ||
| ) | ||
|
|
||
| return result |
Comment on lines
188
to
+192
| if ctx.job_id: | ||
| trace_manager.add_span_exporter(LlmOpsHttpExporter()) | ||
|
|
||
| if trace_file: | ||
| trace_manager.add_span_exporter(JsonLinesFileExporter(trace_file)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.