Fix Apollo Vertex registry CSS vars#869
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
There was a problem hiding this comment.
Pull request overview
Adds missing Apollo-specific CSS variable definitions to several Apollo Vertex registry items and introduces a CI gate to prevent future registry entries from referencing Apollo CSS vars without providing the corresponding cssVars (directly or via registryDependencies). This improves downstream “shadcn registry consumer” reliability by making component installs less dependent on implicit global theme setup.
Changes:
- Extend
apps/apollo-vertex/registry.jsonwithcssVarsblocks for multiple registry items (e.g., Alert, Badge, Button, Card, Sonner, Shell, AI Chat). - Add a strict TypeScript-based scanner that detects Apollo CSS var usage in registry component source and verifies required
cssVarsare provided. - Wire the new scanner into the existing
apollo-vertex-registry-checkworkflow immediately after the registry build step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/apollo-vertex/registry.json | Adds missing cssVars entries so registry items define (or inherit via registryDependencies) the Apollo CSS vars they rely on. |
| .github/workflows/apollo-vertex-registry-check.yml | Runs the new strict CSS var validation step after registry:build. |
| .github/scripts/test-registry/check-css-vars.ts | Implements the registry-wide CSS var requirements scan and fails CI on missing cssVars. |
e48ff5d to
571e784
Compare
Adds missing Apollo CSS variables to registry items that use non-base Tailwind tokens, including button and card. Adds a strict registry check that scans component source for Apollo-specific CSS variable usage and fails CI unless the item or its registry dependencies provide matching cssVars. Wires the check into the existing Apollo Vertex registry workflow after registry build.\n\nValidated with the strict CSS variable check, registry JSON parse, git diff whitespace check, shadcn registry build, and registry index generation.