Skip to content

Fix Apollo Vertex registry CSS vars#869

Merged
ruudandriessen merged 2 commits into
mainfrom
ruudandriessen/shadcn-css-vars
Jul 1, 2026
Merged

Fix Apollo Vertex registry CSS vars#869
ruudandriessen merged 2 commits into
mainfrom
ruudandriessen/shadcn-css-vars

Conversation

@ruudandriessen

Copy link
Copy Markdown
Collaborator

Adds missing Apollo CSS variables to registry items that use non-base Tailwind tokens, including button and card. Adds a strict registry check that scans component source for Apollo-specific CSS variable usage and fails CI unless the item or its registry dependencies provide matching cssVars. Wires the check into the existing Apollo Vertex registry workflow after registry build.\n\nValidated with the strict CSS variable check, registry JSON parse, git diff whitespace check, shadcn registry build, and registry index generation.

Copilot AI review requested due to automatic review settings June 30, 2026 08:13
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jun 30, 2026, 01:27:54 AM
apollo-docs 🟢 Ready Preview, Logs Jun 30, 2026, 01:27:54 AM
apollo-landing 🟢 Ready Preview, Logs Jun 30, 2026, 01:27:54 AM
apollo-vertex 🟢 Ready Preview, Logs Jun 30, 2026, 01:27:54 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1945 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1715
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 34.7% 7.27 MB 27.59 MB ±0
@uipath/apollo-wind 40.1% 392.4 KB 2.55 MB −17 B
@uipath/ap-chat 85.8% 43.41 MB 55.85 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing Apollo-specific CSS variable definitions to several Apollo Vertex registry items and introduces a CI gate to prevent future registry entries from referencing Apollo CSS vars without providing the corresponding cssVars (directly or via registryDependencies). This improves downstream “shadcn registry consumer” reliability by making component installs less dependent on implicit global theme setup.

Changes:

  • Extend apps/apollo-vertex/registry.json with cssVars blocks for multiple registry items (e.g., Alert, Badge, Button, Card, Sonner, Shell, AI Chat).
  • Add a strict TypeScript-based scanner that detects Apollo CSS var usage in registry component source and verifies required cssVars are provided.
  • Wire the new scanner into the existing apollo-vertex-registry-check workflow immediately after the registry build step.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/apollo-vertex/registry.json Adds missing cssVars entries so registry items define (or inherit via registryDependencies) the Apollo CSS vars they rely on.
.github/workflows/apollo-vertex-registry-check.yml Runs the new strict CSS var validation step after registry:build.
.github/scripts/test-registry/check-css-vars.ts Implements the registry-wide CSS var requirements scan and fails CI on missing cssVars.

@ruudandriessen ruudandriessen force-pushed the ruudandriessen/shadcn-css-vars branch from e48ff5d to 571e784 Compare June 30, 2026 08:22
@ruudandriessen ruudandriessen marked this pull request as ready for review June 30, 2026 08:28
@ruudandriessen ruudandriessen requested a review from a team as a code owner June 30, 2026 08:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@ruudandriessen ruudandriessen merged commit 059652c into main Jul 1, 2026
58 checks passed
@ruudandriessen ruudandriessen deleted the ruudandriessen/shadcn-css-vars branch July 1, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants