Skip to content

feat(apollo-vertex): add ShareWithUiPathCheckbox registry component#866

Closed
RobinMennens-UiPath wants to merge 1 commit into
mainfrom
feat/share-with-uipath-checkbox
Closed

feat(apollo-vertex): add ShareWithUiPathCheckbox registry component#866
RobinMennens-UiPath wants to merge 1 commit into
mainfrom
feat/share-with-uipath-checkbox

Conversation

@RobinMennens-UiPath

Copy link
Copy Markdown

Summary

Adds a ShareWithUiPathCheckbox to the apollo-vertex shadcn registry — a labeled opt-in checkbox for the "Share feedback data with UiPath to help troubleshoot and improve the product" consent on Platform Feedback submission surfaces.

Multiple verticals repeat this exact opt-in today (FINS QAQC + LoanSetup, each with an inline Checkbox + Label), so it belongs in the shared registry. This is the source component for the FINS consumer PR (fins-vertical-solution#574) — merge this first.

Design

  • Composition over duplication (per AGENTS.md): builds on the existing @uipath/checkbox + @uipath/label primitives rather than re-implementing.
  • label is a required prop — consumers plug in their own translated, legal-approved string (same pattern as feedback-vote-widget).
  • size variant (smtext-xs, defaulttext-sm) covers the minor typographic differences between the existing call sites.
  • className for wrapper spacing.
  • Collapses Radix's boolean | "indeterminate" to a plain boolean so consumers don't have to.
  • Self-generated useId for the label association.

Validation

  • shadcn build emits r/share-with-uipath-checkbox.json with the right registryDependencies.
  • tsc --noEmit and oxlint --type-aware pass.

🤖 Generated with Claude Code

A labeled opt-in checkbox for the "Share feedback data with UiPath" consent on
Platform Feedback submission surfaces. Composes the existing checkbox + label
primitives; label is a required prop so consumers own their translated,
legal-approved copy. Exposes a `size` variant (sm/default) and a wrapper
`className` for spacing, and collapses Radix's indeterminate state to a plain
boolean for consumers.

Multiple verticals (FINS QAQC + LoanSetup today) repeat this same opt-in, so it
belongs in the shared registry rather than each app.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0199Lti1Py3dBXj5b5NWAuqW
Copilot AI review requested due to automatic review settings June 29, 2026 15:06
@RobinMennens-UiPath RobinMennens-UiPath requested a review from a team as a code owner June 29, 2026 15:06
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jun 29, 2026, 08:11:40 AM
apollo-docs 🟢 Ready Preview, Logs Jun 29, 2026, 08:11:40 AM
apollo-landing 🟢 Ready Preview, Logs Jun 29, 2026, 08:11:40 AM
apollo-vertex 🟢 Ready Preview, Logs Jun 29, 2026, 08:11:40 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1945 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1715
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new reusable shadcn registry UI component to Apollo Vertex for a common “share feedback data with UiPath” consent checkbox pattern, intended to replace duplicated inline Checkbox + Label implementations across vertical solutions.

Changes:

  • Introduces ShareWithUiPathCheckbox, a controlled, labeled checkbox component with a size variant and wrapper className support.
  • Normalizes Radix checkbox state (boolean | "indeterminate") to a plain boolean for consumers.
  • Registers the component in the Apollo Vertex shadcn registry so it can be installed via the @uipath registry namespace.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/apollo-vertex/registry/share-with-uipath-checkbox/share-with-uipath-checkbox.tsx Adds the new composed consent checkbox component using existing registry Checkbox + Label.
apps/apollo-vertex/registry.json Registers the new component in the shadcn registry with its dependencies and file path.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 34.7% 7.27 MB 27.59 MB ±0
@uipath/apollo-wind 40.1% 392.3 KB 2.55 MB −4 B
@uipath/ap-chat 85.8% 43.41 MB 55.85 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@frankkluijtmans frankkluijtmans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't need to go in the registry since it's basically just a regular checkbox. Within a specific vertical client you should de-dupe it though.

@RobinMennens-UiPath

Copy link
Copy Markdown
Author

Closing per discussion with @RobinMennens-UiPath — we decided not to extract this into the vertex registry. It's just a checkbox + label with no real customization, so we'll consolidate it as a local reusable component within the FINS clients instead.

@RobinMennens-UiPath RobinMennens-UiPath deleted the feat/share-with-uipath-checkbox branch June 29, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:M 30-99 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants