Use a fixed list of operations in ReflectionGraphicsStateOperationFac… #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
May 6, 2024
| var result = new Dictionary<string, Type>(); | ||
|
|
||
| foreach (var assemblyType in assemblyTypes) | ||
| private static readonly IReadOnlyDictionary<string, Type> operations = |
There was a problem hiding this comment.
As it stands, operations is instanced to the class, but as the contents is constant, is it ok for it be static instead?
There was a problem hiding this comment.
Now that there is a .NET 8 build, it may or may not be useful to see if using a FrozenDictionary would have any benefits here? (just a thought, i don't have any real experience with using those yet)
There was a problem hiding this comment.
I think that'd be definitely a great use of frozen dictionary here indeed!
There was a problem hiding this comment.
Updated to use FrozenDictionary in the .NET 8.0 build
…tory rather than searching via reflection.
….operations contains all supported graphics operations
|
Updated with an attempt at a unit test for checking that the operations dictionary contains all the operations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory rather than searching via reflection.
The simple approach discussed in #790 , to just use a fix list of operations rather than doing anything clever.
It's a draft for comments, and because we might be able to add tests to
GraphicsStateOperationTeststo compare the fixed list with all the types it finds viaGetOperationTypes()