<textarea> Resizing Issue Fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the textarea element within the settings page with two changes: - The textarea now cannot be resized, and is always set to fill 100% of its container. - The placeholder is now "Enter your own prompt for AI reflections" instead of "Paste an OpenAI API key to enable AI reflections". You can't see this because the textarea is currently readonly, but I assume this will change in the near future.
|
This looks good! :) Will be merged into the next release! |
UdaraJay
added a commit
to khakimov/Pile
that referenced
this pull request
Dec 31, 2023
<textarea> Resizing Issue Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hi @UdaraJay and @khakimov!
This is a super small detail, but what are your thoughts on this?
Before
After
Details
Updated the textarea element within the settings page with two changes:
<textarea>now cannot be resized, and is always set to fill 100% of its container (width: 100%).placeholder="..."is now"Enter your own prompt for AI reflections"instead of"Paste an OpenAI API key to enable AI reflections". You can't see this because the<textarea>is currently readonly, but I assume this will change in the near future. (Feel free to change the this!)Side note: In the future when users are able to edit their AI prompt, maybe deleting
resize: none;and allowing the user to resize the<textarea>vertically would be a good idea.