Skip to content

Add a support for reactive theme #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgonzalez-santiago
Copy link

Currently theme injection is not reactive.

Note: These changes have made the theme variable reactive, which means that we now need to use .value when accessing the theme in the Setup function.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12535c2:

Sandbox Source
jolly-zhukovsky-y37llg Configuration

@pgonzalez-santiago pgonzalez-santiago force-pushed the master branch 4 times, most recently from 0680550 to d3b4ae5 Compare July 20, 2023 10:12
@pgonzalez-santiago
Copy link
Author

pgonzalez-santiago commented Jul 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3b4ae5:

Sandbox Source
affectionate-ishizaka-d58m4n Configuration

Here we have a working example using ThemeProvider from vue3-styled-components https://codesandbox.io/s/dazzling-cerf-f7pgjg?file=/src/App.vue

@pgonzalez-santiago pgonzalez-santiago force-pushed the master branch 2 times, most recently from e01cb84 to 645b949 Compare July 20, 2023 10:42
@juboba
Copy link

juboba commented Oct 11, 2024

@jkempff @liqueflies @codebender828 @alexkharech is this still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants