state manager revamp #274
Open
state manager revamp #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarik-Popov
requested changes
Feb 24, 2024
Yarik-Popov
requested changes
Feb 26, 2024
Navtajh04
requested changes
Mar 6, 2024
|
According to your ticket, you should be handling "3. Must signal the watchdog task at a period of ~X. The watchdog timeout for this task should be 2*X." tho I don't see that here |
Yarik-Popov
requested changes
Mar 25, 2024
Yarik-Popov
requested changes
Jun 8, 2024
|
Has this been tested? |
Like the whole PR? |
Yeah, the PR needs to be tested before anyone will approve it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added the requested states from this ticket
New Changes
Outstanding Changes