ISR Logging #253
Open
ISR Logging #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
Navtajh04
previously requested changes
Nov 29, 2023
dgobalak
previously requested changes
Nov 30, 2023
guhansiyer
dismissed stale reviews from dgobalak and Navtajh04
Discussed in person; changes were unwanted
Krisphy
suggested changes
Mar 20, 2024
Navtajh04
previously requested changes
May 27, 2024
Yarik-Popov
previously requested changes
Sep 8, 2024
guhansiyer
dismissed stale reviews from Yarik-Popov and Navtajh04
Changes addressed
Yarik-Popov
requested changes
Feb 1, 2025
Comment on lines
226
to
+227
| xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken); | ||
| if (xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken) != pdTRUE) { |
There was a problem hiding this comment.
This would send an event twice to the queue. This is not the intended behaviour. Remove the first call
Comment on lines
156
to
+158
| xSemaphoreGiveFromISR(i2cTransferComplete, &xHigherPriorityTaskWoken); | ||
|
|
||
| if (xSemaphoreGiveFromISR(i2cTransferComplete, &xHigherPriorityTaskWoken) == pdTRUE) { |
There was a problem hiding this comment.
This would send an event twice to the queue. This is not the intended behaviour. Remove the first call
| @@ -153,6 +154,12 @@ void i2cNotification(i2cBASE_t *i2c, uint32 flags) { | |||
|
|
|||
| if (flags & I2C_SCD_INT) { | |||
| xSemaphoreGiveFromISR(i2cTransferComplete, &xHigherPriorityTaskWoken); | |||
|
|
|||
| if (xSemaphoreGiveFromISR(i2cTransferComplete, &xHigherPriorityTaskWoken) == pdTRUE) { | |||
| LOG_INFO_FROM_ISR("Semaphore successfully given."); | |||
There was a problem hiding this comment.
We only log on failures so remove this call and only include the else case
| @@ -103,6 +103,7 @@ obc_error_code_t i2cReceiveFrom(uint8_t sAddr, uint16_t size, uint8_t *buf, Tick | |||
|
|
|||
| if (xSemaphoreTake(i2cTransferComplete, transferTimeoutTicks) != pdTRUE) { | |||
| errCode = OBC_ERR_CODE_I2C_TRANSFER_TIMEOUT; | |||
| LOG_ERROR_FROM_ISR("Semaphore cannot be given or was already given."); | |||
There was a problem hiding this comment.
Just log error code using the error code on line 105
| @@ -224,6 +224,9 @@ void alarmInterruptCallback(void) { | |||
|
|
|||
| alarm_handler_event_t event = {.id = ALARM_HANDLER_ALARM_TRIGGERED}; | |||
| xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken); | |||
| if (xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken) != pdTRUE) { | |||
| LOG_ERROR_FROM_ISR("Alarm callback failed."); | |||
There was a problem hiding this comment.
This isnt an alarm callback. This is just an event being sent to the queue that failed. So probably log queue full
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Notion task: https://www.notion.so/uworbital/6375c5c5dcf1485e8a6c47f18d419ae5?v=72baf90d01f643b09d77418bd3f53b14&p=0a4d10df89ca420d899fc3c701b027d0&pm=s
Added logging to appropriate ISRs
New Changes
obc_logging.hin ISRs that are both flagged with__attribute__(weak)and have an existing definition.Testing
Outstanding Changes