Changes #202
Open
Changes #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kepler452b123
requested changes
Jan 12, 2025
lm75bd/lm75bd.h
Outdated
| @@ -5,7 +5,7 @@ | |||
| #include <stdint.h> | |||
|
|
|||
| /* LM75BD I2C Device Address */ | |||
| #define LM75BD_OBC_I2C_ADDR /* Define the address here */ | |||
| #define LM75BD_OBC_I2C_ADDR 0b1001111 | |||
There was a problem hiding this comment.
convert this value to hex for readability
services/thermal_mgr/thermal_mgr.c
Outdated
| while (1) | ||
| { | ||
|
|
||
| thermal_mgr_event_t data = {0}; |
There was a problem hiding this comment.
nitpick: rename to event for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding