Skip to content

Commit

Permalink
Removes PhantomJS, adds test coverage, and more! (#16)
Browse files Browse the repository at this point in the history 
* Closes IAM-150

- Removes support for PhantomJS, replacing it with Chrome as a default.
- Integrates with `tox` for easier, more consistent testing and release.
- Integrates with webdriver-manager for an easier time interacting with driver packages.
- Introduces `pydantic` models for cleaner outputs within the package that have consistent string handling behavior.
- Adds test coverage for both the browser and the plugin.
- Changes tests to use a local example web page instead of a remote site; this allows for control over our tests (and serves to speed them up, too.)
- Generates HTML and terminal coverage reports. View htmlcov/index.html after running `tox`.
  • Loading branch information
Tom Thorogood authored Jun 10, 2020
1 parent 5da46c2 commit 3ef11b0
Show file tree
Hide file tree
Showing 15 changed files with 993 additions and 212 deletions.
88 changes: 75 additions & 13 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,76 @@
.idea
venv
node_modules
ghostdriver.log
*.egg-info
__pycache__
.vscode
webdriver-report/

# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class

# C extensions
*.so

# Distribution / packaging
.Python
env/
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
*.egg-info/
.installed.cfg
*.egg

# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
htmlcov/
.tox/
.coverage
.coverage.*
.cache
.eggs
.*.swp
build
dist
package-lock.json
webdriver-report
nosetests.xml
coverage.xml
*,cover
.hypothesis/
.pytest_cache

# Translations
*.mo
*.pot

# Django stuff:
*.log
local_settings.py

# Flask instance folder
instance/

# Sphinx documentation
docs/_build/

# MkDocs documentation
/site/

# PyBuilder
target/

# IPython Notebook
.ipynb_checkpoints

# pyenv
.python-version

13 changes: 2 additions & 11 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,19 +1,10 @@
language: python
python: ["3.6"]
#
# If we switch from phantomJS to Chrome we'll be happier (KL
#
node_js: node
install:
- pip install -U pip setuptools tox
- git describe --tags > webdriver_recorder/VERSION
- pip install -U pip setuptools
- pip install python-coveralls coverage
#KL #IAM-137## - npm install phantomjs-prebuilt
script:
#KL #IAM-137## - coverage run --source=. --omit='.eggs/*' setup.py test
#KL #IAM-147## - coveralls
- /bin/true
before_deploy:
- tox # This runs tests, runs flake8, and generates a coverage report both in html and in the terminal.
deploy:
skip_cleanup: true
provider: script
Expand Down
210 changes: 200 additions & 10 deletions LICENSE
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,203 @@
Copyright 2018 University of Washington
Copyright 2018 University of Washington

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

http://www.apache.org/licenses/LICENSE-2.0
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright {yyyy} {name of copyright owner}

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
2 changes: 2 additions & 0 deletions MANIFEST.in
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
include webdriver_recorder/report.template.html
inlcude webdriver_recorder/VERSION
51 changes: 41 additions & 10 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,54 @@ of different scenarios. This uses python3.4+ only.
## Installation
```
pip install uw-webdriver-recorder
npm install phantomjs-prebuilt # or use a global phantomjs
```

## Maintaining this plugin

To test this plugin, make sure you have `tox` installed (`pip install tox`) then run `tox`. This will test, lint, and
run coverage reports.

To build this plugin for release, you can do `python setup.py sdist`, to prepare for uploading to PyPI, or you can
install to a local python environment with `pip install .` or even `python setup.py install`. All of these options
should work just fine depending on your needs. A

**A note about local installation:** Installing by any means other than `pip install uw-webdriver-recorder` will
show a version of `0.0.1`; that is because our versioning is managed by our repository tags and is only properly
resolved by our release process.


## Running it
Assume the following file:

```python
"""test_42.py"""
def test_42(browser, report_test):
"""Check the answer."""
browser.get('https://en.wikipedia.org/wiki/42_(number)')
browser.wait_for('body', 'life, the universe, and everything')
```

You would then run the test with
```bash
pytest
```

You can also pass the following options:

```bash
# The directory to store report artifacts. Defaults to ./webdriver-report
--report-dir /path/to/output
# defaults to localhost:4444, only used with the `remote_chrome` fixture
--selenium-server http://some.remote.selenium/endpoint
```

When the test completes, you will have file `webdriver-report/index.html`, with a
screenshot for every `wait_for()` in your test.
screenshot for every `wait_for()` in your test. You can also call `browser.snap()` to take a screenshot at any time.

## Pytest Fixtures

To see examples of these fixtures and how they are used, refer to `tests/test_plugin.py`.

`browser`: The main interface for this plugin. By default, uses Chrome, but you
may substitute your own as needed.

`chrome`: Same as above, but is always Chrome.

`remote_chrome`: (_untested_) A Chrome browser proxy to a running remote selenium server.

`report_dir`: The directory where report artifacts are stored (see above)

`report_generator`: Used to explicitly generate reports. Synonymous with `browser_recorder.plugin.generate_report`
but available as a fixture for convenience. (By default, reports are only generated at the end of a testing session.)
2 changes: 0 additions & 2 deletions setup.cfg
View file

This file was deleted.

Loading

0 comments on commit 3ef11b0

Please sign in to comment.