Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to release workflow template file #6

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

counik
Copy link
Contributor

@counik counik commented Nov 28, 2024

I noticed that there was a large discrepancy between the release-on-push-to-main workflow file here and in netid_arrest (and subsequently the one in sponsor).

Updating the template file to match what's in netid_arrest.

@counik counik requested a review from miker985 November 28, 2024 00:15
@miker985
Copy link
Contributor

miker985 commented Dec 2, 2024

This is excellent, thank you!

It's also part of a larger effort to remove the "fingerprinter" from the workflow entirely.

The fingerprinter isn't something I understand fully but the core functionality appears to be based around optimizing away docker image build times. Our images are pretty lightweight excepting identity-uw, and after discussing with Justin we both agreed it wasn't desirable to have big/heavy images where possible.

@counik counik merged commit 87c9c67 into main Dec 2, 2024
1 of 2 checks passed
@counik counik deleted the counik_actions_update branch December 2, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants