Data structure to store object densities as histogram #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashum68
reviewed
Oct 23, 2024
modules/polar_obstacle_density.py
Outdated
| Create a new SectorObstacleDensity object. | ||
|
|
||
| Parameters: | ||
| - angle_start: The starting angle of the sector cluster. |
There was a problem hiding this comment.
do these parameters have units? i.e. radians? degree? what about density?
modules/polar_obstacle_density.py
Outdated
| @@ -0,0 +1,85 @@ | |||
| """ | |||
| Classes to store object densities as a histogram. | |||
| """ | |||
There was a problem hiding this comment.
small thing - i think theres an extra space here
ashum68
reviewed
Oct 23, 2024
modules/polar_obstacle_density.py
Outdated
| Parameters: | ||
| - angle_start: The starting angle of the sector cluster in degrees | ||
| - angle_end: The ending angle of the sector cluster in degrees | ||
| - density: The calculated obstacle density for this sector. (0 <= density <= 1) |
There was a problem hiding this comment.
How can we interpret these density values? Given a value 0 <= x <= 1, what does x tell me about the obstacles in the sector?
Mmoyv27
force-pushed
the
vfh_structure
branch
from
6bbbb30 to
8f59921
Compare
Mmoyv27
added a commit
that referenced
this pull request
Nov 16, 2024
* Data structure to store object densities as histogram * Added units, removed extra space * Added units for angle-start, angle-end. Clarified and lengthened descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Structure to store object densities as a histogram