Lidar processing #48
Lidar processing #48
Conversation
modules/lidar_oscillation.py
Outdated
| """ | ||
|
|
||
|
|
||
| class LidarReading: |
There was a problem hiding this comment.
we already have a data structure for lidar detections so use that instead. it's called LidarDetection
|
|
||
| class LidarOscillation: | ||
| """ | ||
| Class to represent a collection of LiDAR readings that make up an oscillation. |
There was a problem hiding this comment.
how many degrees are there in one oscillation?
| @classmethod | ||
| def create(cls, readings: list[LidarReading]) -> "tuple[bool, LidarOscillation | None]": | ||
| """ | ||
| Create a new LidarOscillation object from a list of LidarReading objects. |
There was a problem hiding this comment.
create this from a list[LidarDetection]
modules/lidar_oscillation.py
Outdated
| Create a new LidarOscillation object from a list of LidarReading objects. | ||
| """ | ||
| # Ensuring the list only contains LidarReading instances | ||
| if not all(isinstance(reading, LidarReading) for reading in readings): |
There was a problem hiding this comment.
we don't need to check that they are the correct type. just check that the object is not None.
modules/lidar_oscillation.py
Outdated
|
|
||
| return True, LidarOscillation(cls.__create_key, readings) | ||
|
|
||
| def __init__(self, class_private_create_key: object, readings: list) -> None: |
There was a problem hiding this comment.
the type annotation for readings is incorrect
modules/lidar_oscillation.py
Outdated
| """ | ||
| assert class_private_create_key is LidarOscillation.__create_key, "Use the create() method" | ||
|
|
||
| # Store the list of LidarReading objects |
There was a problem hiding this comment.
this comment is not needed
modules/lidar_oscillation.py
Outdated
| """ | ||
| reading_strs = [ | ||
| str(reading) for reading in self.readings | ||
| ] # Create a list of reading strings |
modules/lidar_oscillation.py
Outdated
| reading_strs = [ | ||
| str(reading) for reading in self.readings | ||
| ] # Create a list of reading strings | ||
| return f"LidarOscillation with {len(self.readings)} readings:\n" + "\n".join(reading_strs) |
There was a problem hiding this comment.
reformat to keep strings on one line. you can leave spaces or commas in between readings instead.
There was a problem hiding this comment.
add a period and a space at the end as well
…rDetection objects, adjusted _str_ to print on one line and include all relevant details
Fixed Linting, Creating custom data structures to store lidar oscillations