created multiprocessing worker controller and queue #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.py
Outdated
| @@ -0,0 +1,70 @@ | |||
| """ | |||
There was a problem hiding this comment.
this file should be part of a separate pr
worker/queue_wrapper.py
Outdated
| @@ -0,0 +1,54 @@ | |||
| """ | |||
| Worker Queue | |||
There was a problem hiding this comment.
make sure you have periods at the end of docstrings
worker/queue_wrapper.py
Outdated
Comment on lines
43
to
46
| try: | ||
| self.queue.get(timeout=timeout) | ||
| except queue.Empty: | ||
| return |
There was a problem hiding this comment.
this only removes 1 item from the queue, loop through the maxsize (like the fill function above) to completely drain the queue
worker/queue_wrapper.py
Outdated
| timeout = self.__QUEUE_TIMEOUT | ||
|
|
||
| try: | ||
| self.queue.put(None, timeout=timeout) |
There was a problem hiding this comment.
you don't need this line since it's covered below
worker/queue_wrapper.py
Outdated
|
|
||
| try: | ||
| self.queue.put(None, timeout=timeout) | ||
| for _ in range(1, self.max_size): |
There was a problem hiding this comment.
start the range from 0 to cover above
worker/queue_wrapper.py
Outdated
Comment on lines
44
to
45
| self.queue.get(timeout=timeout) | ||
| for _ in range(1, self.max_size): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.