created flight interface module #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
31
to
37
| args = ( | ||
| FLIGHT_INTERFACE_ADDRESS, | ||
| FLIGHT_INTERFACE_TIMEOUT, | ||
| FLIGHT_INTERFACE_WORKER_PERIOD, | ||
| output_queue, | ||
| controller, | ||
| ) |
There was a problem hiding this comment.
place these within the call to make it clear it's the args for this specific process
tests/unit/test_flight_interface.py
Outdated
Comment on lines
54
to
56
| result, instance = create_flight_interface_instance(None, self.TIMEOUT) | ||
| assert not result | ||
| assert instance is None |
There was a problem hiding this comment.
follow the test set up convention:
- inputs and expected value - expected_result = False, expected_instance = None
- run the thing being tests - actual_result, actual_instance = create_flight_interface...
- assertions - assert actual == expected
tests/unit/test_flight_interface.py
Outdated
Comment on lines
78
to
90
| for _ in range(8): | ||
| result, local_odometry = flight_interface_instance.run() | ||
| assert result | ||
| assert local_odometry is not None | ||
|
|
||
| print("north: " + str(local_odometry.local_position.north)) | ||
| print("east: " + str(local_odometry.local_position.east)) | ||
| print("down: " + str(local_odometry.local_position.down)) | ||
| print("roll: " + str(local_odometry.drone_orientation.roll)) | ||
| print("pitch: " + str(local_odometry.drone_orientation.pitch)) | ||
| print("yaw: " + str(local_odometry.drone_orientation.yaw)) | ||
| print("timestamp: " + str(local_odometry.timestamp)) | ||
| print("") |
There was a problem hiding this comment.
we don't having prints in tests because we don't look at this output, unit tests are always assertions, this function can be part of the integration test
…avoidance into flight_interface
fetching worker methods
ashum68
added a commit
that referenced
this pull request
Jun 10, 2024
* created data structure to hold local odometry data * created flight interface module * added multiprocessing worker and conversion methods * reformatting * added type annotations * added init function docstrings * removed drone_odometry_local data structure * added integration test * added unit tests * removed conversions unit test * added init file and file docstrings * added type annotations * rearranged imports * changed integration test variable name to silence linter * added pymap3d to requirements * added print statements to integration test * removed print statements from unit test * reformatting * debugging * fixed imports * created flight interface module * added multiprocessing worker and conversion methods * reformatting * added type annotations * added init function docstrings * added integration test * added unit tests * removed conversions unit test * added init file and file docstrings * added type annotations * rearranged imports * changed integration test variable name to silence linter * added pymap3d to requirements * added print statements to integration test * removed print statements from unit test * reformatting * debugging * fixed imports * debugged unit test, rebased with main * debugged unit test * removed mission planner tests * debugging * reformatting * rearranged imports * changed timeout from int to float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.