Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created data structure to hold local odometry data #2

Merged
merged 7 commits into from
May 29, 2024
Merged

Conversation

ashum68
Copy link
Contributor

@ashum68 ashum68 commented May 28, 2024

No description provided.

Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed


from .common.mavlink.modules import drone_odometry

class DronePositionLocal:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include string representation function

cls.__create_key, local_position, drone_orientation, timestamp
)

def __init__(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a docstring for this function

self.drone_orientation = drone_orientation
self.timestamp = timestamp

def __str__(self) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a docstring for this function

Copy link
Contributor

@TongguangZhang TongguangZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashum68 ashum68 merged commit 92a91e4 into main May 29, 2024
1 check passed
@ashum68 ashum68 deleted the data_structure branch May 29, 2024 20:42
@ashum68 ashum68 restored the data_structure branch May 30, 2024 18:39
@ashum68 ashum68 deleted the data_structure branch June 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants