Skip to content

Commit

Permalink
Made final review change for empty check
Browse files Browse the repository at this point in the history
  • Loading branch information
Mmoyv27 committed Oct 22, 2024
1 parent 28f503b commit 9d7c788
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions modules/lidar_oscillation.py
Original file line number Diff line number Diff line change
@@ -19,7 +19,8 @@ def create(
"""
Create a new LidarOscillation object from a list of LidarReading objects.
"""

if not readings:
return False, None
return True, LidarOscillation(cls.__create_key, readings)

def __init__(
@@ -32,13 +33,8 @@ def __init__(

self.readings = readings
angles = [reading.angle for reading in readings]

if angles:
self.min_angle = min(angles)
self.max_angle = max(angles)
else:
self.min_angle = None
self.max_angle = None
self.min_angle = min(angles)
self.max_angle = max(angles)

def __str__(self) -> str:
"""

0 comments on commit 9d7c788

Please sign in to comment.