Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart worker patch with fixed commit history #237

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Restart worker patch with fixed commit history #237

merged 7 commits into from
Jan 22, 2025

Conversation

Adityya-K
Copy link
Contributor

@Adityya-K Adityya-K commented Jan 16, 2025 •
edited
Loading

This is a new PR for the restart workers that fixes the messy commit history and implements some new changes.

Some things to note:

  • I have only commented out the code that drains the queue just in case it is needed for the program to run
  • Additionally, I don't quite understand how the queues are added to the new workers or if anything needs to be done to add them, so, if there are glaring flaws, I apologize

HermanG05
HermanG05 approved these changes Jan 22, 2025
View reviewed changes
Copy link

@HermanG05 HermanG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally Approved. Just address the two comments and push your changes before merging.

modules/communications/communications_worker.py Outdated

if is_invalid:
continue

result, value = comm.run(input_queue.queue.get())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the argument with input_data

modules/communications/communications_worker.py Outdated
@@ -6,6 +6,8 @@
import pathlib
import queue

from modules import object_in_world

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space

@Adityya-K Adityya-K merged commit def8f2d into main Jan 22, 2025
1 check passed
@Adityya-K Adityya-K deleted the restart_workers_patch_new branch January 22, 2025 15:52
@Adityya-K Adityya-K restored the restart_workers_patch_new branch January 22, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HermanG05 HermanG05 HermanG05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adityya-K @HermanG05