Added a communication worker for logging cluster estimation #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmunication worker
…ocal-global conversion.
wdan31
force-pushed
the
comm-worker-logs-cluster
branch
from
36df1a7 to
8ff6035
Compare
Xierumeng
reviewed
Nov 22, 2024
|
|
||
| objects_in_world_global.append(object_in_world_global) | ||
|
|
||
| timestamp = time.time() |
modules/communications/log_to_kml.py
Outdated
There was a problem hiding this comment.
This should be in a separate PR in repository common.
…mmunication worker
…ocal-global conversion.
maxlou05
force-pushed
the
comm-worker-logs-cluster
branch
from
8ff6035 to
92c3299
Compare
maxlou05
reviewed
Nov 22, 2024
| if not result: | ||
| # Log nothing if at least one of the conversions failed | ||
| self.__logger.warning( | ||
| f"drone_position_global_from_local conversion failed:\nhome_position: {self.__home_position}\nobject_position_local: {object_position_local}" |
There was a problem hiding this comment.
I think you still need to change this to position global from position local
maxlou05
reviewed
Nov 27, 2024
config.yaml
Outdated
| @@ -39,3 +39,6 @@ cluster_estimation: | |||
| min_activation_threshold: 25 | |||
| min_new_points_to_run: 5 | |||
| random_state: 0 | |||
|
|
|||
| communications: | |||
| timeout: 10.0 # seconds | |||
There was a problem hiding this comment.
Can we make this timeout longer, like 30 seconds? I feel like main_2024 takes a while to boot up
main_2024.py
Outdated
Comment on lines
448
to
452
| for cluster in cluster_estimations: | ||
| main_logger.debug("Cluster in world: " + True) | ||
| main_logger.debug("Cluster in world: ", True) | ||
| main_logger.debug("Cluster location x: " + str(cluster.location_x)) | ||
| main_logger.debug("Cluster location y: " + str(cluster.location_y)) | ||
| main_logger.debug("Cluster spherical variance: " + str(cluster.spherical_variance)) |
There was a problem hiding this comment.
Can we remove all of this and just log logger.debug(f"clusters: {detections_in_world}") as it is in cluster_estimation_worker?
modules/communications/log_to_kml.py
Outdated
There was a problem hiding this comment.
Please delete this. Evan or I will move it to post-processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.