Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker controller exit request deadlock #160

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions utilities/workers/worker_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,20 @@ def check_pause(self):
def request_exit(self):
"""
Requests worker processes to exit.
Does nothing if already requested.
"""
time.sleep(self.__QUEUE_DELAY)
self.__exit_queue.put(None)
if self.__exit_queue.empty():
self.__exit_queue.put(None)

def clear_exit(self):
"""
Clears the exit request condition.
Does nothing if already cleared.
"""
time.sleep(self.__QUEUE_DELAY)
if not self.__exit_queue.empty():
self.__exit_queue.get()
_ = self.__exit_queue.get()

def is_exit_requested(self) -> bool:
"""
Expand Down
Loading