Camera Widget Implementation #31
Conversation
There was a problem hiding this comment.
So far so good! I'll need you to factor out the camera widget into it's own file, see the other widgets in the widgets directory to see how we handle comments and general style. You also need to write unit tests for the widget, this could also be super easy, you only need to check for existence and attributes. Also can create a thread for this in the PR channel in Discord and post an image of it working? I don't get a camera feed on my PC but I'm pretty sure it's because I have my webcam configured weird.
| @@ -32,7 +32,7 @@ class MavlinkCommunication { | |||
| switch (_connectionType) { | |||
| case MavlinkCommunicationType.tcp: | |||
| log('[$moduleName] Trying to start TCP connection'); | |||
| _startupTcpPort(connectionAddress, tcpPort); | |||
| //_startupTcpPort(connectionAddress, tcpPort); | |||
There was a problem hiding this comment.
Why is this commented out? Might be a mistake please undo this.
| @override | ||
| Widget build(BuildContext context) { | ||
| return Scaffold( | ||
| body: Camera( |
There was a problem hiding this comment.
factor out Camera and it's controller to a separate widget in the widgets directory. I know it's kinda pedantic but we want the most flexibility possible to react to pilot feedback.
|
Is there any updates on this? |
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
You need to complete this file to pass CI/CD
| import 'package:imacs/widgets/nav_bar_widget.dart'; | ||
| import 'package:imacs/widgets/camera_widget.dart'; | ||
|
|
||
| class CameraScreen extends StatelessWidget { |
There was a problem hiding this comment.
Add doc strings to file, see other files for examples
| const PlaceholderScreen(title: 'Logs'), | ||
| '/camera': (BuildContext context) => | ||
| const PlaceholderScreen(title: 'Camera'), | ||
| '/logs': (BuildContext context) => const LogDisplayerScreen( |
There was a problem hiding this comment.
Keep the logs screen as a placeholder for now
| import 'package:camera_universal/camera_universal.dart'; | ||
|
|
||
| /// Widget to display camera feed | ||
| class CameraWidget extends StatefulWidget { |
There was a problem hiding this comment.
Make the doc string more descriptive
|
|
||
| /// Widget to display camera feed | ||
| class CameraWidget extends StatefulWidget { | ||
| final CameraController cameraController = CameraController(); |
There was a problem hiding this comment.
This value is never used, you can remove this and make the constructor const
| task(); | ||
| } | ||
|
|
||
| Future<void> task() async { |
There was a problem hiding this comment.
rename function to be more descriptive and add doc string
| return Scaffold( | ||
| body: Camera( | ||
| cameraController: cameraController, | ||
| onCameraNotInit: (context) { |
There was a problem hiding this comment.
add log messages to each of the fail states
Implemented the camera widget, code directly from camera_universal package with naming changed to match context