Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modules pages for Membership check, events, login,involvement. Added apis for membership check and login. Integrated Dev Link API #800

Open
wants to merge 2 commits into
base: front-end
Choose a base branch
from

Conversation

GansaK
Copy link
Contributor

@GansaK GansaK commented Jan 28, 2024

Description of the Change

I have added modules pages for Membership check, events, login, and involvement. Added APIs for membership check and login. Integrated Dev Link API

Applicable Issues

The login button does not do anything for now. I will be adding a toast and redirect on successful login.

…Added apis for membership check and login. Integrated Dev Link API
Copy link
Contributor

@ludvigalden ludvigalden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, but there is a lot of duplicate code and mismatches with the front-end branch. So I won't be able to merge anything into the front-end branch before they are "in sync". For now, I added the changes with fixes to commit b8cf5ba and #788. I did not include the log-in page because it should be structured very differently, since the authentication should be synced between all pages and you should be able to log in and sign up in all three modules (member, involvement, event), we need some authentication context, automatic token refresh, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants