Refactor professor course and section pipelines into a pipeline builder function #296
Conversation
|
@ruba0s, as for merge conflicts, ideally, you should pull the new changes to your local first, manually resolve those conflicts, and push them back. Resolving shouldn't take very long if those conflicts are not really related to what you are working on. |
|
@mikehquan19 Sounds good! Once I'm done with that and want to commit merge, should I choose commit updates to the develop branch or create a new branch and commit updates? |
|
You commit merge to whichever branch you are working on, don’t create a new branch. |
api/controllers/professor.go
Outdated
|
|
||
| // paginate the sections | ||
| bson.D{{Key: "$skip", Value: paginateMap["latter_offset"]}}, | ||
| bson.D{{Key: "$limit", Value: paginateMap["limit"]}}, |
There was a problem hiding this comment.
I believe these 3 last stages here are essentially the same (since they all sort and paginate the latter object whether it's course or section), so you could potentially put them after (or before?) conditions.
Other than that, this one should be ready for merging!
| }}}, | ||
|
|
||
| // keep order deterministic between calls | ||
| bson.D{{Key: "$sort", Value: bson.D{{Key: "_id", Value: 1}}}}, |
There was a problem hiding this comment.
I think $sort could belong to the pagination stages since they are supposed to be sorted right before we paginate the second time
| }}}, | ||
|
|
||
| // replace the combination of ids and courses with the courses entirely | ||
| bson.D{{Key: "$replaceWith", Value: "$courses"}}, |
There was a problem hiding this comment.
As you can see here $unwind and $replaceWith are kind of repeated between 2 branches. Can you come up with the way to add them to pagination stages too and just replace the value with the endpoint parameters?
| return append(append(baseStages, sectionStages...), paginationStages...) | ||
| } | ||
|
|
||
| return append(baseStages, paginationStages...) // fallback (shouldn't happen because we call with either courses or sections) |
There was a problem hiding this comment.
I think here we don't need a fallback, if the endpoint is invalid we will just panic :)
2 participants
No description provided.