Implement apply_within_conjugate for Hermitian adjoint Hamiltonian application #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Plan for apply_within_conjugate
Summary
Updated implementation based on feedback from @hzhangxyz. The key change is the iteration strategy:
Previous (incorrect): Iterate over configs (larger), search in result_configs (smaller)
Now (correct): Sort configs (larger), iterate over result_configs (smaller), search in sorted configs
This is more efficient when result_configs is smaller than configs, which is the primary use case for the conjugate operation.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.