Skip to content

ci: Refactor workflow versions to use 'latest' and remove env vars #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzhangxyz merged 2 commits into from
Jan 1, 2026
Merged

ci: Refactor workflow versions to use 'latest' and remove env vars #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac4133
ci: use 'latest' string instead of version env vars in workflows
hzhangxyz Jan 1, 2026
03de02b
fix(bnf-pytest): use 'latest' python version in build job
hzhangxyz Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/bnf-jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- pull_request
- push

env:
NODE_LATEST_VERSION: '24'

jobs:
jest:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -60,7 +57,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_LATEST_VERSION }}
node-version: latest
cache: 'npm'

- name: version
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/bnf-pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- pull_request
- push

env:
PYTHON_LATEST_VERSION: '3.14'

jobs:
pytest:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -54,7 +51,7 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:
python-version: ${{ matrix.python-version }}
python-version: latest
enable-cache: true

- name: build
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/egg-jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- pull_request
- push

env:
NODE_LATEST_VERSION: '24'

jobs:
jest:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -54,7 +51,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_LATEST_VERSION }}
node-version: latest
cache: 'npm'

- name: version
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/egg-pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- pull_request
- push

env:
PYTHON_LATEST_VERSION: '3.14'

jobs:
pytest:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -48,7 +45,7 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:
python-version: ${{ env.PYTHON_LATEST_VERSION }}
python-version: latest
enable-cache: true

- name: build
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:

env:
EM_CACHE_FOLDER: 'emsdk-cache'
NODE_LATEST_VERSION: '24'

jobs:
jest:
Expand Down Expand Up @@ -62,13 +61,13 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: ${{ env.NODE_LATEST_VERSION }}
node-version: latest
cache: 'npm'

- uses: actions/cache@v5
with:
path: ${{ env.EM_CACHE_FOLDER }}
key: jest-em-cache-${{ runner.os }}-${{ env.NODE_LATEST_VERSION }}
key: jest-em-cache-${{ runner.os }}
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key for the emsdk cache has been simplified to remove the Node version component. However, this creates a mismatch with the jest job above (line 32), which still uses jest-em-cache-${{ runner.os }}-${{ matrix.node-version }} as its cache key. This means the npm job will not be able to reuse the cache created by the jest job, potentially impacting build performance. Consider aligning both cache keys to use the same pattern.

Copilot uses AI. Check for mistakes.

- uses: pyodide/setup-emsdk@v15
with:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- pull_request
- push

env:
PYTHON_LATEST_VERSION: '3.14'

jobs:
pytest:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -51,7 +48,7 @@ jobs:

- uses: actions/setup-python@v6
with:
python-version: ${{ env.PYTHON_LATEST_VERSION }}
python-version: latest
cache: 'pip'

- name: install cibuildwheel
Expand Down Expand Up @@ -79,7 +76,7 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:
python-version: ${{ env.PYTHON_LATEST_VERSION }}
python-version: latest
enable-cache: true

- name: build sdist
Expand Down