Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme and documentation #1124

Merged
merged 24 commits into from
Apr 14, 2023
Merged

update readme and documentation #1124

merged 24 commits into from
Apr 14, 2023

Conversation

cmaimone
Copy link
Contributor

This PR has a series of changes to help with website update procedures, clarify policies, break up the documentation into smaller pieces, and update the PR template.

@cmaimone
Copy link
Contributor Author

See the policies branch to preview readme and other documentation pages on github: https://github.com/USRSE/usrse.github.io/tree/policies

docs/details.md Outdated Show resolved Hide resolved
docs/details.md Outdated Show resolved Hide resolved
docs/events.md Outdated Show resolved Hide resolved
It's helpful to write out a listing of timezones in the content, e.g.,:

```md
The next community call will be on August 12, 2021 at 12ET/11CT/10MT/9PT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out what format we want to use for these. I personally don't like these without a space between the number and the timezone... But maybe this is what others decided we are doing to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just grabbed a recent example - happy to put in a different format if there are suggestions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we've had any agreement on this, but the website group could make the decision

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should at least be spaces and the time zone abbreviations should be complete, e.g., "August 12, 2021 at 12pm EDT/11am CDT/10am MDT/9am PDT".

docs/events.md Outdated Show resolved Hide resolved
docs/events.md Outdated Show resolved Hide resolved
docs/feeds.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
cmaimone and others added 6 commits April 12, 2023 18:57
Co-authored-by: Daniel S. Katz <[email protected]>
Co-authored-by: Daniel S. Katz <[email protected]>
Co-authored-by: Daniel S. Katz <[email protected]>
Co-authored-by: Daniel S. Katz <[email protected]>
Co-authored-by: Daniel S. Katz <[email protected]>
Co-authored-by: Daniel S. Katz <[email protected]>
docs/details.md Outdated Show resolved Hide resolved
docs/events.md Outdated Show resolved Hide resolved
docs/events.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
@mtbc
Copy link
Contributor

mtbc commented Apr 13, 2023

Presumably due to multiple original authors, there's various inconsistency as one reads through, e.g, do we capitalize JSON, RSS, URL, etc.? Do we hyphenate US-RSE? Do we put backticks around literal filenames? Perhaps outwith this PR, as a followup, we ought to decide such style stuff then do a round of fixes. (Could be right alongside fixing how we specify times/zones.)


cc @usrse-maintainers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure usrse-maintainers will still be notified on PR creation without this line but I just want to confirm that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that they will be notified, but regardless, that's not quite the right group. When sorting out the groups, I made usrse-maintainers non-SC members with merge permissions, and then there's a SC group as well. I think we want people putting the PR on Slack when they're ready for review? Especially because people need to preview and check tests first (so don't really want to alert folks until it's really ready). But maybe we do want some @ a group in the template?

cmaimone and others added 4 commits April 13, 2023 09:29
Co-authored-by: Mark T. B. Carroll <[email protected]>
Co-authored-by: Mark T. B. Carroll <[email protected]>
Co-authored-by: Mark T. B. Carroll <[email protected]>
@cmaimone
Copy link
Contributor Author

On the style inconsistencies - yes, it's been written by multiple people. I didn't do a full copyedit - just tried to sort out the info as the primary goal. Anyone who wants to do a consistency/editing pass would be appreciated, but perhaps after the PR is merged would be best. Want to get general buy-in on the reorganization, basic content, and policy revisions first.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work, @cmaimone !

README.md Outdated Show resolved Hide resolved
docs/details.md Show resolved Hide resolved
docs/details.md Outdated Show resolved Hide resolved
docs/details.md Outdated Show resolved Hide resolved
docs/details.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
cmaimone and others added 4 commits April 13, 2023 09:48
Co-authored-by: Miranda Mundt (she/her) <[email protected]>
Co-authored-by: Miranda Mundt (she/her) <[email protected]>
Co-authored-by: Miranda Mundt (she/her) <[email protected]>
Co-authored-by: Miranda Mundt (she/her) <[email protected]>
README.md Outdated Show resolved Hide resolved
docs/tests_ci.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cmaimone
Copy link
Contributor Author

I'm not sure about the images on tests_ci.md. I'm going to go ahead and merge everything here though, and we can address any remaining issues with additional PRs. I left the issue of multiple timezone formatting to decide later #1126

@cmaimone cmaimone merged commit 1803798 into main Apr 14, 2023
@cmaimone cmaimone deleted the policies branch April 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants