Fixes to issue 9 #10
Merged
Fixes to issue 9 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2018 16:02
…check so that empty fastq records will not be written, udated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes several issues:
An issue with parsing of HMMER domtable files. The score for the whole hmm profile was being used not the score for exact alignment of the profile. In some cases a profile aligned twice and itsxpress would just take the first profile rather than taking the highest scoring alignment.
There was a second error in how the highest scoring segment was being selected. The score was being treated as a string not a floating point value so it would occasionally select a lower scoring segment which sometimes had the wrong position (e.g. the string '6.3' < '20.1' while the float 6.2 < 20.1). The Qiime2 authors were wise to require static typing...
The error that Qiime was producing about "line 17" is actually the result of itsxpress writing empty sequences because it was using bad position information. A check was added to not write sequences where the length was less than 1 even though that should not happen any longer.