Fix issue with not sorting columns for reduced vars #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that objects are sorting correctly in all columns, largest mod is first
|
LGTM. Do you plan to do anything else soon or should I ship this off to CRAN? |
|
Hi Malcolm,
It should be good to go! No other changes planned.
Thanks!
K
…----------------------------
*Katelyn "KJ" Queen, Ph.D.*
***@***.***
Keck School of Medicine, University of Southern California
On Sat, May 18, 2024 at 1:28 PM Malcolm Barrett ***@***.***> wrote:
LGTM. Do you plan to do anything else soon or should I ship this off to
CRAN?
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/USCbiostats/partition/pull/37*issuecomment-2118995613__;Iw!!LIr3w8kk_Xxm!qy6SChUrgSTVgvHSv6yhDxHGMUtfjeZ9n9RvE3XMSXGSQRek5Xg5sWaqbbkVGQzIC52N9RNPJvVR5fHYLOS2ssUl$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/APUJNAJCJPOF5IX5V2OMP4TZC62WPAVCNFSM6AAAAABH4QVH4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHE4TKNRRGM__;!!LIr3w8kk_Xxm!qy6SChUrgSTVgvHSv6yhDxHGMUtfjeZ9n9RvE3XMSXGSQRek5Xg5sWaqbbkVGQzIC52N9RNPJvVR5fHYLBRu9KKh$>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks, the fix is on its way to CRAN! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Malcolm,
We found a bug in the last step of the sorting process. Previously, the code was resorting rows without resorting the columns, leading to problems with indices not matching. This fixes that.
Thanks,
K