Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMS-283 - Add syncOfficeStaff to Offices use case #918

Merged
merged 18 commits into from
Sep 20, 2024
Merged

CAMS-283 - Add syncOfficeStaff to Offices use case #918

merged 18 commits into from
Sep 20, 2024

Conversation

btposey
Copy link
Contributor

@btposey btposey commented Sep 19, 2024

Purpose

Add office staff to offices repo

Major Changes

  • Added syncOfficeStaff function to offices use case
  • Function gets groups and users from the IdP
  • Function maps groups to roles and offices
  • Function writes staff records to the office repo

Testing/Validation

Enumerate on steps to validate that this feature is working.

@btposey btposey marked this pull request as ready for review September 19, 2024 22:01
@btposey btposey requested review from a team as code owners September 19, 2024 22:01
@btposey
Fix broken getOfficeAttorneys test
91ccefc 
Jira ticket: CAMS-283
btposey
btposey commented Sep 20, 2024
View reviewed changes
common/src/cams/staff.ts Outdated Show resolved Hide resolved
backend/functions/lib/use-cases/offices/offices.ts
officesWithUsers.push(office);
}

// TODO: What to do with users with roles WITHOUT offices?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can chase this down in a follow on PR.

@btposey btposey merged commit 5310d5c into main Sep 20, 2024
14 checks passed
@btposey btposey deleted the CAMS-283-office-staff-sync branch September 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorrow-flexion amorrow-flexion amorrow-flexion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btposey @amorrow-flexion