Cams 282 auditable #901
Merged
Cams 282 auditable #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira ticket: CAMS-282
We want to avoid a number of issues related to the ability to handle multiple optional parameters. We now only accept a record and the user. Jira ticket: CAMS-282 Co-authored-by: Fritz Madden <[email protected]> Co-authored-by: Arthur Morrow <[email protected]> Co-authored-by: Brian Posey <[email protected]>,
jamesobrooks
temporarily deployed
to
Develop
GitHub Actions
Inactive
jamesobrooks
temporarily deployed
to
Develop
GitHub Actions
Inactive
btposey
approved these changes
Sep 16, 2024
jamesobrooks
temporarily deployed
to
Develop
GitHub Actions
Inactive
fmaddenflx
reviewed
Sep 16, 2024
| ); | ||
| assignment.updatedOn = currentDate; |
There was a problem hiding this comment.
Curious why we decided to update "updatedOn" after creating the audit record. I see we did this also on line 127. I must have missed the reasoning behind that.
fmaddenflx
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to document the reason for the creation and proper use of
auditable.ts.Major Changes
Add an ADR.