Fix cases-runtime-state test and logging

Jira ticket: CAMS-421

Co-authored-by: Brian Posey <[email protected]>

backend/lib/use-cases/dataflows/cases-runtime-state.test.ts

@@ -15,27 +15,43 @@ describe('storeRuntimeState tests', () => {
     jest.restoreAllMocks();
   });
 
-  test('should persist a new sync state', async () => {
+  test('should persist a new sync state and log', async () => {
     jest.spyOn(MockMongoRepository.prototype, 'read').mockResolvedValue(undefined);
     const upsertSpy = jest
       .spyOn(MockMongoRepository.prototype, 'upsert')
       .mockResolvedValue(undefined);
 
     const lastSyncDate = new Date().toISOString();
+    const errorLogSpy = jest.spyOn(context.logger, 'camsError');
+    const infoLogSpy = jest.spyOn(context.logger, 'info');
     await CasesRuntimeState.storeRuntimeState(context, lastSyncDate);
     expect(upsertSpy).toHaveBeenCalledWith({
       documentType: 'CASES_SYNC_STATE',
       lastSyncDate,
     });
+    expect(errorLogSpy).not.toHaveBeenCalled();
+    expect(infoLogSpy).toHaveBeenCalledWith(
+      expect.any(String),
+      expect.stringContaining('Wrote runtime state: '),
+      expect.anything(),
+    );
   });
 
-  test('should throw CamsError', async () => {
+  test('should log CamsError', async () => {
     const original: CasesSyncState = {
       documentType: 'CASES_SYNC_STATE',
       lastSyncDate: '1000',
     };
     jest.spyOn(MockMongoRepository.prototype, 'read').mockResolvedValue(original);
     jest.spyOn(MockMongoRepository.prototype, 'upsert').mockRejectedValue(new Error('some error'));
+    const errorLogSpy = jest.spyOn(context.logger, 'camsError');
+    const infoLogSpy = jest.spyOn(context.logger, 'info');
     await expect(CasesRuntimeState.storeRuntimeState(context, '1001')).resolves.toBeUndefined();
+    expect(errorLogSpy).toHaveBeenCalled();
+    expect(infoLogSpy).not.toHaveBeenCalledWith(
+      expect.any(String),
+      expect.stringContaining('Wrote runtime state: '),
+      expect.anything(),
+    );
   });
 });

backend/lib/use-cases/dataflows/cases-runtime-state.ts

@@ -13,7 +13,7 @@ async function storeRuntimeState(context: ApplicationContext, lastSyncDate: stri
       lastSyncDate,
     };
     await runtimeStateRepo.upsert(newSyncState);
-    context.logger.info(MODULE_NAME, `Wrote runtime state: ${newSyncState}.`);
+    context.logger.info(MODULE_NAME, `Wrote runtime state: `, newSyncState);
   } catch (originalError) {
     const error = getCamsError(
       originalError,