-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/data export #815
base: dev
Are you sure you want to change the base?
Fix/data export #815
Conversation
Gonna break this into separate comments cause it's getting long. The first issue is a critical performance issue on the vetting page on initial load. This must be resolved before this update can go in. It renders the page unresponsive until the garbage collector kicks in. Possibly the new export parsing code is getting rerun on every dom refresh. Will debug later tonight. Images are from devtools perfmonitor, no throttling, cache enabled. Below, I am getting cpu spikes at 100% for about 20 seconds in Chrome (top pink arrow) when I load the Vetting page, and the jsheap shoots from 20mb to 350mb or so (middle pink arrow). For comparison, the little spike at the black arrow is from loading the Flights page. For comparison, I ran it again in the dev branch (below). Flight page load is the black arrow, pink is the Vetting page. We don't have hard perf requirements to meet, but the load should look more or less like this. |
Export column issues:
We should discuss Monday whether to add a separate export button just for Excel or do the text conversion for the existing one. |
|
^ Agreed. So the only piece left is nailing down the performance issue which is on my todo list. |
This resolves #780
**sortType**
props that help us to pass a customized sort function for each column