Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling #21

Merged
merged 9 commits into from
Oct 17, 2019
Merged

Tooling #21

merged 9 commits into from
Oct 17, 2019

Conversation

steven-murray
Copy link
Collaborator

@steven-murray steven-murray commented Oct 17, 2019

This adds a number of new tooling/package restructure things:

  1. Puts the package in src/
  2. Uses setup.cfg instead of setup.py primarily
  3. Adds a bunch of flake8 checks and plugins to both pre-commit and tox
  4. Adds a skeleton tests/ directory and TRAVIS tooling
  5. Makes changes to files consistent with the flake8 checks
  6. Adds a docs/ directory and skeleton, but no actual docs
  7. Adds AUTHORS and CHANGELOG, but no CONTRIBUTING
  8. Adds some instructions to the README for development (probably should be moved to CONTRIBUTING when that is done).
  9. Sets up tox
  10. Sets up coveragerc

The main thing to be checked here are the flake8 plugins and options -- whether we want all these (or more!).

Addresses #21
Addresses #11

Copy link
Member

@plaplant plaplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steven-murray! I'll get tests up and running once we've merged this in.

I just have a couple of small comments.

AUTHORS.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@plaplant
Copy link
Member

@steven-murray looks like there are some merge conflicts that need to be resolved as well.

Copy link
Member

@plaplant plaplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steven-murray!

@plaplant plaplant merged commit b7670ae into master Oct 17, 2019
@plaplant plaplant deleted the tooling branch October 17, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants