Skip to content

Conversation

@epelc
Copy link

@epelc epelc commented May 16, 2024

Refactor and clean up token generation for go to use the latest best practices(everything besides making this repo go gettable).

  • Remove all panics and add proper error handling
  • Add timeouts to http client and context for production usage
  • Use stdlib builtins where appropriate(ie basic auth)
  • Several performance improvements by not repeating work
  • Update error to use go format of lower case error strings

Update README.md to match api

Update go readme to match api.

  • Fix language reference "Go programming language" not "GO Lang"
  • Remove unused queryParams option
  • Update install/setup docs. This file does not require go install since it is using only the standard library. Also these docs were using incorrect syntax anyways.

Refactor token generation

- Remove all panics and add proper error handling
- Add timeouts to http client and context for production usage
- Use stdlib builtins where appropriate
- Several performance improvements by not repeating work
- Update error to use go format of `lower case error strings`

Update README.md to match api

Update go readme to match api.

 - Fix language reference "Go programming language" not "GO Lang"
- Remove unused queryParams option
- Update install/setup docs. This file does not require go install since it is using only the standard library. Also these docs were using incorrect syntax anyways.
@epelc
Copy link
Author

epelc commented May 16, 2024

This also has many naming convention fixes. You can find official recommendations here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant