Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to poetry, fix readthedocs yaml, fix GitHub Actions and update README #17

Merged
merged 24 commits into from
Sep 15, 2023

Conversation

prakaa
Copy link
Contributor

@prakaa prakaa commented Aug 1, 2023

Changes:

  1. Migrated to poetry for dependency management. setup.py has been removed, and support for Python 3.7 removed (unsupported now)
  2. Add testing in workflow for pull requests
  3. Read the Docs yaml has been fixed up - uses poetry
    • Untested because I don't have access to RtD management for nempy
  4. GitHub actions implements matrix testing using poetry across all OSs. This appears to be working
  5. Changes to README to condense information
    • Figure link is currently hard linked to transparent PNG which doesn't work well for dark themes. Best to replace with PNG with white background, and add relative link to joss-paper branch

Probably best to squash and merge if you accept this PR - lots of incremental commits

@prakaa prakaa requested a review from nick-gorman August 1, 2023 00:24
@mlee94
Copy link
Contributor

mlee94 commented Aug 16, 2023

Possible to remove pandas<2.0.0 in the poetry dependencies? New version of pandas introduces some good in-memory efficiencies. Hopefully doesn't break any tests or anything.

@prakaa
Copy link
Contributor Author

prakaa commented Aug 16, 2023

Possible to remove pandas<2.0.0 in the poetry dependencies? New version of pandas introduces some good in-memory efficiencies. Hopefully doesn't break any tests or anything.

Yup good suggestion @mlee94. Have specified >= 2.0. Doesn't appear to break tests

prakaa and others added 2 commits September 15, 2023 10:15
Change accuracy plot to white background
@nick-gorman
Copy link
Member

I've changed the plot on the readme to have a white background, but kept the hard coding for now.

added publish action based on NEMSEER example
@nick-gorman
Copy link
Member

I've also added action based publishing to pypi

@nick-gorman nick-gorman merged commit 12b95fc into UNSW-CEEM:master Sep 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants