Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include downloadable KML of map #30

Merged
merged 193 commits into from
Jan 24, 2024
Merged

Include downloadable KML of map #30

merged 193 commits into from
Jan 24, 2024

Conversation

cchristiansen
Copy link
Contributor

Include functionality to allow download of spatial circuit data as a KML file. Changes include:

  1. including button to download KML file
  2. documentation in documentation tab
  3. additional out_of_tool_processing tool to create voltage label KMLs from CSVs.

@cchristiansen
Fix trailing space and misspelling
ffcb78f
@cchristiansen
Clean up BDInterface
dd03f8a
@cchristiansen
Clean up BDInterface
c42ff29
@cchristiansen
Fix indentation and formatting
13be193
@cchristiansen
Minor fixes
cc7871e
@cchristiansen
Rename BDInterface to db_interface
4d51792
@cchristiansen
Correct spelling
70ebb03
@cchristiansen
Correct BDInterface to db_interface
bb45099
@cchristiansen
Fix warning for test_data_cleaning_functions
599fae4
@cchristiansen
Capitalise as to AS.
8394381
@cchristiansen
Cleaner comment and query
148d5cd
@cchristiansen
Minor formatting edits
69c8222
@cchristiansen
Capitalise SQL commands
7579022
@cchristiansen
provide namespace of function
1c133fe
@cchristiansen
col_width max of 120, not 80
db5958b
@cchristiansen
Clean up comments
0dfd359
@cchristiansen
Slowly get rid of sqldf
3a03352 
sqldf doesn't seem to be maintained anymore, so try to remove it as a
dependency.
@cchristiansen
line wrap at 120 not 80 characters
73d0c61
@cchristiansen
Correct documentation
038eb1a
@cchristiansen
Fix spelling and add a few more column aliases
77c0e73
@cchristiansen
Spelling fixes
6bd0c64
@cchristiansen
Fix up messages split over multiple lines
9713fb4
@cchristiansen
useShinyalert is now redundant
a884ce0 
Get rid to remove warning message as well.
@cchristiansen
Remove trailing spaces
7eda989
@cchristiansen
Minor formatting changes
8f4979c
@cchristiansen
Fix spelling bug
6c53ce0
@cchristiansen
Formatting changes
98778ff
@cchristiansen
Fix formatting
640103e
@cchristiansen
Formatting changes
5926b0a
@cchristiansen
Formatting changes
5c788c5
@cchristiansen
Add spacing
e0bc71a
@cchristiansen
nafill only works with numerics
3276cd0 
So have to use replace_na when using characters/strings.
@cchristiansen
Be consistent and use vector of column names
83b4c75
@cchristiansen
Match combined_data$s_postcode with distances$postcode
6214624
@cchristiansen
httpuv needed for 4.2.2 on windows-latest
2451983
@cchristiansen
Load httpuv for R 4.2.2 on windows-latest
3fc3a75
@cchristiansen
Change R version to 4.2.3
e1a779d 
Since it's the last stable 4.2 R release.
@cchristiansen
Debugging
c483ce3
@cchristiansen
Debugging
8e4ad2e
@cchristiansen
Remove httpuv because it may not be required
4dc2e09
@cchristiansen
Can't do replace_na since it's a logical vector
7fc86fe 
Change to be a character vector.
@cchristiansen
Address comments by Phoebe
351cf89
@cchristiansen
Use dplyr piping
ede01a4
@cchristiansen
Couple of extra fixes after implementing dplyr piping
9d6dd97
@cchristiansen
Create KML
2e4a92b
@cchristiansen
Generate KMLs
5f5f0ed
@cchristiansen
Implemented KML map export
42d636c
@cchristiansen
Merge branch 'master' into map
d329da0
@cchristiansen
Merge branch 'master' into map
409bde1
@cchristiansen
Create voltage label KML
38cda9e 
Also create test for checking that it works correctly.
@cchristiansen
Remove unneeded TODO
8c635ba
@cchristiansen
Fix typo
77b2f8b
phoebeheywood
phoebeheywood approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@phoebeheywood phoebeheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this Christian, all looks good to me!

@cchristiansen cchristiansen merged commit a98cb9e into master Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoebeheywood phoebeheywood phoebeheywood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cchristiansen @phoebeheywood