DERDAT 1s duration option #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Cynthujah
commented
Dec 20, 2023
Cynthujah
commented
- 1s input option is added in "shiny.R"
- 1s option is added in "flag_duration_for_updating_if_value_non_standard_and_calced_interval_is_5s" function in "interface.R"
Adding_input_duration_1s in shiny.R
change in criteria in "flag_duration_for_updating_if_value_non_standard_and_calced_interval_is_5s" function for the definition of flag duration.
1s input option is added in shiny.R
NAs are removed during the mean voltage calculations.
down-sampling of "ideal response" is ignored while analyzing 1s data because "ideal response" is already with 1s duration. Only column name "time_group" is changes to match with the existing data-frame.
Potential modification for "Ideal Response Curve" is suggested in "Assumptions and Methodology" tab of GUI
…mpliance Status" Minor discrepancies in the definition of "Reconnection Compliance Status" is identified and mentioned in the documentation for future reference.
Cynthujah
requested review from
phoebeheywood,
cchristiansen and
Naomi-Stringer
and removed request for
Naomi-Stringer
"post event response" is down-sampled to 5s, only for 1s data analysis, for the definition of "reconnection status".
Down-sampling is done for data with 1s duration to 5s for "post_event_response" and the other duration are allowed with the previous "post_event_response" calculations.
Calculation of "post_event_response" is downsampled from 1s to 5s. Test file is created for dwonsampling.
Spacing in the added lines of codes in "island_assessment_function.R" and "ufls_detection_voltage.R" are resolved.
phoebeheywood
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.