Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix update column aliases for new data format #28

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Hotfix update column aliases for new data format #28

merged 2 commits into from
Jan 8, 2024

Conversation

phoebeheywood
Copy link
Collaborator

The column names expected in the database creation have been updated to reflect the new format that data is provided in.

@cchristiansen
Copy link
Contributor

cchristiansen commented Dec 20, 2023 •
edited
Loading

The tests are currently failing since db_interface/tests/test_data_getter.R, db_interface/tests/test_db_build.R and db_interface/tests/test_db_build_new_format.R still use the old format. These test scripts will have to be updated too.

cchristiansen
cchristiansen approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@cchristiansen cchristiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me!

@phoebeheywood phoebeheywood merged commit 031f827 into master Jan 8, 2024
4 checks passed
@phoebeheywood phoebeheywood deleted the hotfix-data-cols-changed branch January 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchristiansen cchristiansen cchristiansen approved these changes

@Naomi-Stringer Naomi-Stringer Awaiting requested review from Naomi-Stringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phoebeheywood @cchristiansen