Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add logging when dcm2niix skips dcm images #326

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dcm2bids/dcm2niix_gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,12 @@ def execute(self):
shutil.rmtree(self.rm_tmp_dir)
self.logger.info("Temporary dicom directory removed.")

if "Warning" in output or "Error" in output:
if "Warning" in output or "Error" in output or "Skipping" in output:
self.logger.info("Log from dcm2niix execution")
if "Warning" in output:
self.logger.warning(f"{output}")
else:
if "Error" in output:
self.logger.error(f"{output}")
else:
self.logger.warning(f"{output}")
else:
self.logger.debug(f"\n{output}")
self.logger.info("Check log file for dcm2niix output\n")
Expand Down
Loading