Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates: move to D11 #628

Merged
merged 9 commits into from
Mar 27, 2025
Merged

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-10683

Copy link

github-actions bot commented Mar 13, 2025

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.3.19 (cli) (built: Mar 15 2025 02:40:35) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.19, Copyright (c) Zend Technologies with Zend OPcache v8.3.19, Copyright (c), by Zend Technologies with Xdebug v3.4.2, Copyright (c) 2002-2025, by Derick Rethans Composer version 2.8.6 2025-02-25 13:03:50
Drupal Logs
PHP Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

@lazysoundsystem lazysoundsystem requested a review from attiks March 26, 2025 16:49
@attiks
Copy link
Contributor

attiks commented Mar 27, 2025

@lazysoundsystem
Copy link
Contributor Author

Thanks - I'll make a new major version of ocha_key_figures for D11 (though this is the only site which uses it).

I don't think I have permissions to push to ocha_visualisations: UN-OCHA/ocha_visualisations#1 (I didn't a couple of weeks ago).

@attiks
Copy link
Contributor

attiks commented Mar 27, 2025

Access granted

@lazysoundsystem
Copy link
Contributor Author

Thanks for the prompt - all cleaned up now and ready for review.

@attiks
Copy link
Contributor

attiks commented Mar 27, 2025

Patches are still present?

@lazysoundsystem
Copy link
Contributor Author

Sorry, they weren't pushed - they are now.

Copy link
Contributor

@attiks attiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Coverage Report

Totals Coverage

@lazysoundsystem lazysoundsystem merged commit 921e415 into develop Mar 27, 2025
3 checks passed
@lazysoundsystem lazysoundsystem deleted the feature/OPS-10683-D11-upgrade branch March 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants