Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3주차 미션 - 밍붕 #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

3주차 미션 - 밍붕 #9

wants to merge 1 commit into from

Conversation

kingmingseo
Copy link
Collaborator

Merge pull request는 모든 리뷰가 완료된 후에 눌러주세요!

1. Add a title

  • N주차미션 - 닉네임으로 수정해 주세요! ex) 1주차 미션- 테비

2. Reviewers

  • Reviewers(리뷰어)에 팀원을 등록해 주세요! (최소 1명)

3. Assignees

  • Assignees(PR 담당자)에 본인을 등록해 주세요!

4. Labels

  • Labels에 mission 태그를 등록해 주세요!

Comment on lines +30 to +31
grid-template-areas: 'logo ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ button';
grid-template-columns: repeat(10, 1fr);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<Link to={'/category'}>
<SideMenu>
<MdMovie />
&nbsp; 영화
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SideMenu 스타일에서 justify-content: space-around;를 추가하고 width 값을 조정하면 &nbsp 없이 스타일을 조정할 수 있어요!

Comment on lines +3 to +6
import cbr from '../assets/cbr500r.png';
import ninja from '../assets/ninja.png';
import rocket from '../assets/rocket.png';
import r1 from '../assets/r1.png';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 개인적으로 이렇게 import 문이 길어질 때 정리하고 싶더라구요.. 혹시 민서님도 그렇다면 assets 폴더에 아래처럼 index.js를 추가하고

// index.js
export { default as cbr } from "./cbr500r.png";
export { default as ninja } from "./ninja.png";
export { default as r1 } from "./r1.png";
export { default as rocket } from "./rocket.png";
export { default as watcha } from "./watcha.png";

category.jsx에서는 import { cbr, ninja, r1, rocket } from "../assets"; 이렇게 깔끔하게 한 줄로 정리가 가능하답니다!

Comment on lines +8 to +9
let { id } = useParams();
id = id || 'popular';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 id가 falsy한 값을 띄면 'popular'가 할당이 될 거여서 const으로 하는 것이 좋습니다! 혹시 이름이 겹쳐서 고민이시라면 아래처럼도 가능해요!

Suggested change
let { id } = useParams();
id = id || 'popular';
const { id: paramId } = useParams();
const id = paramId || "popular";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants