Add stream_read/write verifiers

UIUC-ChenLab · Feb 15, 2024 · 73e8373 · 73e8373
1 parent 8d436f7
commit 73e8373
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/lib/Dialect/HLS/IR/HLSOps.cpp b/lib/Dialect/HLS/IR/HLSOps.cpp
@@ -253,9 +253,19 @@ void StreamOp::getEffects(
 //===----------------------------------------------------------------------===//
 
 LogicalResult StreamReadOp::verify() {
+  auto channelType = getChannel().getType();
   if (getResult())
-    if (getChannel().getType().getElementType() != getResult().getType())
+    if (channelType.getElementType() != getResult().getType())
       return emitOpError("result type doesn't align with channel type");
+
+  auto loops = getSurroundingLoops(*this, getChannel().getParentBlock());
+  auto tripCounts = getLoopTripCounts(loops);
+  auto steps = getLoopSteps(loops);
+  if (!tripCounts || !steps ||
+      channelType.getIterTripCounts() != ArrayRef<int64_t>(*tripCounts) ||
+      channelType.getIterSteps() != ArrayRef<int64_t>(*steps))
+    return emitOpError("iteration trip counts or steps doesn't align with "
+                       "stream type's iteration trip counts or steps");
   return success();
 }
 
@@ -271,8 +281,18 @@ void StreamReadOp::getEffects(
 //===----------------------------------------------------------------------===//
 
 LogicalResult StreamWriteOp::verify() {
-  if (getChannel().getType().getElementType() != getValue().getType())
+  auto channelType = getChannel().getType();
+  if (channelType.getElementType() != getValue().getType())
     return emitOpError("value type doesn't align with channel type");
+
+  auto loops = getSurroundingLoops(*this, getChannel().getParentBlock());
+  auto tripCounts = getLoopTripCounts(loops);
+  auto steps = getLoopSteps(loops);
+  if (!tripCounts || !steps ||
+      channelType.getIterTripCounts() != ArrayRef<int64_t>(*tripCounts) ||
+      channelType.getIterSteps() != ArrayRef<int64_t>(*steps))
+    return emitOpError("iteration trip counts or steps doesn't align with "
+                       "stream type's iteration trip counts or steps");
   return success();
 }
 

diff --git a/lib/Dialect/HLS/IR/HLSTypes.cpp b/lib/Dialect/HLS/IR/HLSTypes.cpp
@@ -109,7 +109,7 @@ bool hls::StreamType::isConvertableWith(RankedTensorType tensor) const {
     return false;
   if (getDataType() != tensor.getElementType())
     return false;
-  if (getShape() != SmallVector<int64_t>(tensor.getShape()))
+  if (ArrayRef<int64_t>(getShape()) != tensor.getShape())
     return false;
   return true;
 }