feat(ui5-popover): implement resizable popover #12623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12623--ui5-webcomponents.netlify.app |
alexandar-mitsev
requested changes
Dec 19, 2025
Member
alexandar-mitsev
left a comment
alexandar-mitsev
left a comment
There was a problem hiding this comment.
(partial review)
- the error for popovers without opener is back
To reproduce - set resizable: true for all popovers at Popover.html test page.
The console has the exception:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
at PopoverResize.getResizeHandlePlacement (PopoverResize.ts?t=1766136059469:80:31)
at PopoverResize.setCorrectResizeHandleClass (PopoverResize.ts?t=1766136059469:57:18)
Member
Author
Done |
alexandar-mitsev
requested changes
Dec 19, 2025
alexandar-mitsev
requested changes
Jan 8, 2026
alexandar-mitsev
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3384
Certain styles for slotted elements in the footer and header are overridden, similar to how it is done in the UI5 dialog.
fixes #8167
fixes #12088