Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dockerfile #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide Dockerfile #18

wants to merge 2 commits into from

Conversation

kuanb
Copy link
Member

@kuanb kuanb commented Apr 21, 2017

Note, relates to Issue: #12

Dockerfile provides a clean, consistent environment for development and execution of library.

Making it available if desired. :)

@kuanb
Copy link
Member Author

kuanb commented Apr 26, 2017

Not to rope @jalessio into this 😃 , but v helpful critique of this Dockerfile. Will revisit and make edits (again, just should anyone find this of use):

  1. "too many layers… consolidate all those multiline commands into a single RUN like you have for the GEO libraries. Also, running apt-get update and apt-get install in separate RUN commands is a bit of an anti-pattern for a Dockerfile"

  2. "also, I think you’re doing the “cleanup” step too early in the process — you should so that at the end, since the apt commands you run for GEOS will just re-populate /var/lib/apt"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant