Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ProcessPeakJob execution #120

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Removed ProcessPeakJob execution #120

merged 4 commits into from
Jun 6, 2024

Conversation

kjallen
Copy link
Member

@kjallen kjallen commented Jun 5, 2024

This is part 1 of resolving the ProcessPeakJob wav form generation. This PR completely removes the call of ProcessPeakJob calls, but does not remove the function definition.

If wav form image data already exists, it will not be removed when re-importing a record. If the record is new, a wav form image will not be created. Existing wav form image data is in JSON format and stored in Solr.

To confirm:

Compare an existing entry that has a wav form image to our local instance

@kjallen kjallen requested a review from akohler June 5, 2024 03:06
Copy link
Member

@akohler akohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjallen I've tested this and it does what it should. Confirmed that if local record had a wave form image (for me, imported against the main branch), then re-imported on the new branch, the wave form image was not removed. And if local record had no wave form image, re-importing on the new branch did not change that, it still had no wave form image.

I pushed a commit to flesh out the Linux-specific instructions, and added a "recipe" for connecting to the database via docker-compose, simpler than the instructions you removed.

I'm merging this, then will deploy to stage so you can test it there.

@akohler akohler merged commit cc0088c into main Jun 6, 2024
1 check passed
@akohler akohler deleted the SYS-1616/remove_wav_gen branch June 6, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants