Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Join Us" page styling changes and added section #170

Open
wants to merge 2 commits into
base: new_site_dev
Choose a base branch
from

Conversation

lakshman8664
Copy link

@lakshman8664 lakshman8664 commented Nov 20, 2024

Join us page updated to look like Figma. Added section for External Board Teams. Descriptions extended in 'Opportunities' and 'How Do We Operate?' sections to fit wireframe. Opportunities section updated to look like new wireframe. https://www.figma.com/design/njhHulJqQ8BSfohyR1DPel/Nov-2024%3A-CL-Wireframe-Update?node-id=29-2068&node-type=frame&t=ZUJI9Sg1XxJZvRjr-0

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<div className="flex flex-col items-center mb-8">
{image && (
<div className="w-32 h-32 overflow-hidden rounded-full mb-4">
<img
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<a href={src} target="_blank" className={`border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className="flex flex-col items-center w-full space-y-4 group">
<img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg group-hover:scale-110 transition ease-in-out duration-300" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<div className={`group p-4 border-2 border-black-300 rounded-lg transition-transform duration-300 hover:scale-105 ${className}`}>
<div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}>
<img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

return (
<div className={`group p-4 border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}>
<img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

return (
<div className={`group p-4 border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}>
<img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

return (
<a href={src} target="_blank" className={`border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className="flex flex-col items-center w-full space-y-4 group">
<img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg group-hover:scale-110 transition ease-in-out duration-300" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<div className={`group p-4 border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}>
<img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<div className="border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105">
<div className="flex flex-col items-center w-full space-y-4">
<img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

…oard Teams. Descriptions extended in 'Opportunities' and 'How Do We Operate?' sections to fit wireframe. Updated 'Opportunities' section to match new wireframe with images and descriptions.
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

return (
<a href={src} target="_blank" className={`border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className="flex flex-col items-center w-full space-y-4 group">
<img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg group-hover:scale-110 transition ease-in-out duration-300" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<div className={`group p-4 border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}>
<div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}>
<img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

return (
<div className="border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105">
<div className="flex flex-col items-center w-full space-y-4">
<img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

Copy link
Member

@olliepai olliepai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make the following changes~

  1. make the image for the "Socials and Workshops" card the same height as the other two images
  2. remove the subheadings under each role (the "[24/7]" and "[Before the start of each quarter]"
  3. add text that says "Click card to view application" at the bottom of the Project Lead and Project Member cards. Do this in place of the link at the bottom of those cards (the Figma currently shows links).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants