Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sjl edits #73

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Sjl edits #73

merged 2 commits into from
Feb 18, 2025

Conversation

sam0287
Copy link
Collaborator

@sam0287 sam0287 commented Feb 17, 2025

I've made some small edits and also a suggestion to emphasise somewhere how flexibly Barker can be defined in the package (e.g. bi-modal). We should probably say something about this but I can't remember exactly how flexibly it can be defined. Maybe you can add something?

Also added coda reference, wanted to add simTools as well but I'm not sure it's been made available on CRAN.

Copy link
Collaborator

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sam0287, these edits all look good to me, will merge this and add in a comment on flexibility in choosing noise distribution in #71

@matt-graham matt-graham merged commit 19bc22a into mmg/joss-paper Feb 18, 2025
2 checks passed
@matt-graham matt-graham deleted the sjl_edits branch February 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants