Conversation
mscroggs
commented
Mar 19, 2025
3 tasks
Collaborator
willGraham01
left a comment
willGraham01
left a comment
There was a problem hiding this comment.
Working example 🥳 🚀
Couple of small ruff-please-ers in the Graph class.
For the algorithms module, I'm not convinced as to why the methods in there can't be part of the Graph class itself, but I'm open to being convinced.
The test comments are mostly on a reduction in the number of cases. The two example tests have 16 & 32 test cases, respectively (which is not a bad thing, but some are likely redundant in terms of what they check).
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
…nto mscroggs/normal-example
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
…nto mscroggs/normal-example
willGraham01
approved these changes
Mar 20, 2025
Collaborator
willGraham01
left a comment
willGraham01
left a comment
There was a problem hiding this comment.
Have put a few small suggestions in (if you agree with them, it should just be a case of "apply suggestion" and things won't break), otherwise looks good to go!
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
Co-authored-by: Will Graham <32364977+willGraham01@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.