You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recent changes to the WebRTC package and the compliance with Vulkan is very much appreciated.
I am however still running into issues with WebRTC and the Meta-SDK (which would be worth opening another issue but I don't have time to properly investigate this right now)
Currently for the AddPackageWebRTC.cs script we have the following: #if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK)
In the Unity VOIP implementation files we have the definitions #if UNITY_WEBRTC || UNITY_WEBRTC_UBIQ_FORK
This combination of symbols currently doesn't allow for one to say: "I don't want WebRTC at all" which would be practical for my use case since I'm not using the VOIP services from Ubiq. (or well I customized them partially because of issue #52)
E.g the additon of another symbol like: #if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK) && !UBIQ_DISABLE_WEBRTC
Would already resolve this issue for us.
I can however understand that this isn't necessary desirable and I understand why the current implementation is the way it is.
I'd be happy about any response/feedback to this request :)
The text was updated successfully, but these errors were encountered:
TheBv
changed the title
Request: Option to completely disable WEBRTC import
Request: Option to completely disable WebRTC
Nov 30, 2024
I think this is a good idea, and one extra pre-processor symbol doesn't seem too bad a cost. We'll need to introduce it to the other backends and add a fallback to the null implementation on all platforms.
I had wanted to make the backend configurable with some kind of UI which would also address the issue, but it'd likely just take too long to implement.
Before this makes it in in some form, it might work to define the UNITY_WEBRTC symbol yourself as part of your scripting symbols.
The recent changes to the WebRTC package and the compliance with Vulkan is very much appreciated.
I am however still running into issues with WebRTC and the Meta-SDK (which would be worth opening another issue but I don't have time to properly investigate this right now)
Currently for the
AddPackageWebRTC.cs
script we have the following:#if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK)
In the Unity VOIP implementation files we have the definitions
#if UNITY_WEBRTC || UNITY_WEBRTC_UBIQ_FORK
This combination of symbols currently doesn't allow for one to say: "I don't want WebRTC at all" which would be practical for my use case since I'm not using the VOIP services from Ubiq. (or well I customized them partially because of issue #52)
E.g the additon of another symbol like:
#if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK) && !UBIQ_DISABLE_WEBRTC
Would already resolve this issue for us.
I can however understand that this isn't necessary desirable and I understand why the current implementation is the way it is.
I'd be happy about any response/feedback to this request :)
The text was updated successfully, but these errors were encountered: