Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Option to completely disable WebRTC #58

Open
TheBv opened this issue Nov 30, 2024 · 1 comment
Open

Request: Option to completely disable WebRTC #58

TheBv opened this issue Nov 30, 2024 · 1 comment

Comments

@TheBv
Copy link
Contributor

TheBv commented Nov 30, 2024

The recent changes to the WebRTC package and the compliance with Vulkan is very much appreciated.
I am however still running into issues with WebRTC and the Meta-SDK (which would be worth opening another issue but I don't have time to properly investigate this right now)

Currently for the AddPackageWebRTC.cs script we have the following:
#if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK)
In the Unity VOIP implementation files we have the definitions
#if UNITY_WEBRTC || UNITY_WEBRTC_UBIQ_FORK

This combination of symbols currently doesn't allow for one to say: "I don't want WebRTC at all" which would be practical for my use case since I'm not using the VOIP services from Ubiq. (or well I customized them partially because of issue #52)

E.g the additon of another symbol like:
#if !UNITY_WEBRTC_UBIQ_FORK && !(UNITY_WEBRTC && UBIQ_DISABLE_WEBRTCCOMPATIBILITYCHECK) && !UBIQ_DISABLE_WEBRTC
Would already resolve this issue for us.

I can however understand that this isn't necessary desirable and I understand why the current implementation is the way it is.

I'd be happy about any response/feedback to this request :)

@TheBv TheBv changed the title Request: Option to completely disable WEBRTC import Request: Option to completely disable WebRTC Nov 30, 2024
@bnco-dev
Copy link
Contributor

bnco-dev commented Dec 3, 2024

I think this is a good idea, and one extra pre-processor symbol doesn't seem too bad a cost. We'll need to introduce it to the other backends and add a fallback to the null implementation on all platforms.

I had wanted to make the backend configurable with some kind of UI which would also address the issue, but it'd likely just take too long to implement.

Before this makes it in in some form, it might work to define the UNITY_WEBRTC symbol yourself as part of your scripting symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants